Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UndertowHttpHandlerAdapter to dispatch #33885

Closed
rstoyanchev opened this issue Nov 14, 2024 · 3 comments
Closed

Update UndertowHttpHandlerAdapter to dispatch #33885

rstoyanchev opened this issue Nov 14, 2024 · 3 comments
Assignees
@simonbasle
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
6.2.0

Comments

@rstoyanchev
Copy link
Contributor

As per the discussion under https://issues.redhat.com/browse/UNDERTOW-2512, UndertowHttpHandlerAdapter needs to start async handling explicitly by calling dispatch.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 14, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0 milestone Nov 14, 2024
@simonbasle simonbasle self-assigned this Nov 14, 2024
@philwebb philwebb mentioned this issue Nov 14, 2024
Closed
@philwebb
Copy link
Member

philwebb commented Nov 14, 2024 •
edited
Loading

Will this one be backported as some point?

@simonbasle
Copy link
Contributor

The plan is to backport it to 6.1.x at some point indeed. We want to be a tiny bit more cautious with upgrading the Undertow baseline in the existing 6.1.x line, and delaying the backport could be an opportunity to gather feedback on the change from 6.2.

@simonbasle simonbasle added the for: backport-to-6.1.x Marks an issue as a candidate for backport to 6.1.x label Nov 26, 2024
@github-actions github-actions bot added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-6.1.x Marks an issue as a candidate for backport to 6.1.x labels Nov 26, 2024
@github-actions github-actions bot mentioned this issue Nov 26, 2024
Closed
simonbasle added a commit that referenced this issue Nov 26, 2024
@simonbasle
Dispatch in UndertowHttpHandlerAdapter
dd32f95 
This ensures that the reactive handling of the request is dispatched
from the Undertow IO thread, marking the exchange as async rather than
ending it once the Undertow `handleRequest` method returns.

See gh-33885
Closes gh-33969
@simonbasle
Copy link
Contributor

@philwebb this has now been backported to 6.1.x, available in 6.1.16 snapshots 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
3 participants
@rstoyanchev @philwebb @simonbasle