Add support for creating Time Series collection. #3732
Conversation
Introduce time series to CollectionOptions and add dedicated TimeSeries annotation to derive values from.
| * | ||
| * @return never {@literal null}. | ||
| */ | ||
| String timeField(); |
There was a problem hiding this comment.
Staying close to the MongoDB terminology for Time Series collections seemed to be a valid choice here.
| * | ||
| * @return empty {@link String} by default. | ||
| */ | ||
| String metaField() default ""; |
There was a problem hiding this comment.
how about just meta or meta property?
There was a problem hiding this comment.
Staying close to the MongoDB terminology for Time Series collections seemed to be a valid choice here. Simply meta does IMO not express that this is a field reference rather than a proved meta object/value.
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ ElementType.TYPE }) | ||
| @Document | ||
| public @interface TimeSeries { |
There was a problem hiding this comment.
Alternatively, we could have annotations for the timeseries field and the meta field, similar to text-indexed language for consistency.
There was a problem hiding this comment.
The @Language field allows to override the defaults defined via @Document so I do not think this is a good fit here since you may not override any of those fields on a per document basis for Time Series collections where it's rather a fixed value at collection creation time.
Rename Granularities/Granularity to Granularity and GranularityDefinition to proivide a more natural wording towards using predefined granularities. Validate presence of referenced properties through the TimeSeries annotation. Tweak Javadoc, reformat code, add unit tests. See #3731 Original pull request: #3732.
|
That's merged and polished now. |
Introduce time series to
CollectionOptionsand add dedicated@TimeSeriesannotation to derive values from.