Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mapping of connectionRequestTimeout to ConnPool leaseTimeout #1926

Closed
sothawo opened this issue Sep 10, 2021 · 1 comment · Fixed by #1925
Closed

Change mapping of connectionRequestTimeout to ConnPool leaseTimeout #1926

sothawo opened this issue Sep 10, 2021 · 1 comment · Fixed by #1925
Labels
type: bug A general bug
Milestone
4.3 M3 (2021.1.0)

Comments

@sothawo
Copy link
Collaborator

sothawo commented Sep 10, 2021

(Description taken from PR#1925)

Currently the RestClients.create() method sets the underlying RequestConfig connectTimeout and connectionRequestTimeout properties to the value of the ClientConfiguration connectTimeout property.

The connectionRequestTimeout is used as the leaseTimeout parameter when calling the AbstractNIOConnPool lease method, which can lead to a "TimeoutException: Connection lease request time out" on an establised connection.

The correct behavior is to use the sockerTimeout property for the leastTimeout parameter.
@sothawo sothawo added the type: bug A general bug label Sep 10, 2021
@sothawo sothawo added this to the 4.3 M3 (2021.1.0) milestone Sep 10, 2021
sothawo pushed a commit that referenced this issue Sep 10, 2021
@nichines @sothawo
Change mapping of connectionRequestTimeout to ConnPool leaseTimeout.
92806d2 
Original Pull Request: #1925
Closes: #1926

(cherry picked from commit 3b8f0c9)
sothawo pushed a commit that referenced this issue Sep 10, 2021
@nichines @sothawo
Change mapping of connectionRequestTimeout to ConnPool leaseTimeout.
ea4cc07 
Original Pull Request: #1925
Closes: #1926

(cherry picked from commit 3b8f0c9)
(cherry picked from commit 92806d2)
@sothawo sothawo linked a pull request Sep 10, 2021 that will close this issue
Change mapping of connectionRequestTimeout to ConnPool leaseTimeout #1925
Merged
@sothawo
Copy link
Collaborator Author

sothawo commented Sep 10, 2021

backported to branches 4.2.x and 4.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
4.3 M3 (2021.1.0)
1 participant
@sothawo