Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSourceTransactionManagerAutoConfiguration should not enable DataSourceProperties as it does not use them #43603

Closed
wants to merge 1 commit into from
Closed

DataSourceTransactionManagerAutoConfiguration should not enable DataSourceProperties as it does not use them #43603

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 24, 2024

DataSourceProperties bean is not used by DataSourceTransactionManagerAutoConfiguration.

@quaff
Remove unnecessary @EnableConfigurationProperties
aac8a35 
DataSourceProperties bean is not used by DataSourceTransactionManagerAutoConfiguration.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 24, 2024
@philwebb
Copy link
Member

Thanks @quaff. I think just to be safe, we'll wait until 3.5 to merge this one. I think the extra @EnableConfigurationProperties is harmless in the meantime.

@philwebb philwebb added this to the 3.5.x milestone Dec 24, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 24, 2024
@wilkinsona wilkinsona changed the title Remove unnecessary @EnableConfigurationProperties DataSourceTransactionManagerAutoConfiguration should not enable DataSourceProperties as it does not use them Jan 2, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: task A general task labels Jan 2, 2025
@wilkinsona
Copy link
Member

I've changed this to an enhancement, primarily so that it will appear in the changelog.

@snicoll snicoll modified the milestones: 3.5.x, 3.5.0-M1 Jan 7, 2025
@snicoll snicoll self-assigned this Jan 7, 2025
snicoll pushed a commit that referenced this pull request Jan 7, 2025
@quaff @snicoll
Remove unnecessary creation of DataSourceProperties
1ecf1f3 
This commit removes the creation of DataSourceProperties in
DataSourceTransactionManagerAutoConfiguration as the latter does not
use the former.

See gh-43603
@snicoll snicoll closed this in 2505038 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M1
Development

Successfully merging this pull request may close these issues.
5 participants
@quaff @philwebb @wilkinsona @snicoll @spring-projects-issues