Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce eager task creation in the build #29827

Conversation

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 16, 2022
@wilkinsona wilkinsona changed the title Avoid eager task creation inside the spring boot build Reduce eager task creation inside the spring boot build Feb 17, 2022
@wilkinsona wilkinsona changed the title Reduce eager task creation inside the spring boot build Reduce eager task creation in the build Feb 17, 2022
@wilkinsona
Copy link
Member

Thanks, Lars. Unfortunately, these changes seem to expose a bug (or some misconfiguration in our build) where a ConcurrentModificationException is thrown. Some experimentation suggests that the problem's been fixed in Gradle 7.x but I am not 100% sure as I don't fully understand the failure.

We haven't really had any significant problems with the time taken to configure tasks so I don't think we can really justify potentially destabilising the build at this time. Thanks anyway.

If it's any consolation, looking at this did make me realise that spring-io/spring-javaformat#319 would be a good thing to do. In Spring Boot's build, the Java Format Plugin's eagerly creating over 1000 tasks so we should see a significant reduction once 0.0.32 is released and Boot's build has been upgraded.

@wilkinsona wilkinsona closed this Feb 23, 2022
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants