Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to dozer-spring-boot-starter #13501

Closed
wants to merge 1 commit into from
Closed

Add reference to dozer-spring-boot-starter #13501

wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

@kazuki43zoo kazuki43zoo commented Jun 17, 2018 •
edited
Loading

The Dozer is the Java Bean mapper. Since the Dozer 6.2.0(current latest version), the dozer-spring-boot-starter module was added. Hence; I will introduce the it as community starter.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 17, 2018
@kazuki43zoo kazuki43zoo mentioned this pull request Jun 17, 2018
Closed
snicoll
snicoll requested changes Jun 18, 2018
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

There is no need to add an extra explanation to what Dozer is (other entries in this file don't).

Also, entries are sorted alphabetically. Can you please push force an update to your branch that put this entry at the right place?

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jun 18, 2018
@bclozel
Copy link
Member

bclozel commented Jun 18, 2018

Looking at the Dozer starter, it seems it is only compatible with Spring Boot 1.5 - is that the case?
In the meantime, we're thinking about pruning the current list from starters incompatible with Spring Boot 2.x. This should be done on the master/2.0.x branches.

Depending on the outcome of that discussion in #13510, this PR could be declined.

@kazuki43zoo
Copy link
Contributor Author

@bclozel @snicoll Thanks for your replying!
I will consult it with a maintainer of dozer.

@kazuki43zoo
Copy link
Contributor Author

@bclozel
I've added the compatibility checker project on my account. See https://github.com/kazuki43zoo/dozer-spring-boot-compatibility-checker. The dozer-spring-boot-starter 6.2.0 depends on Spring Boot 1.5.x, but it works fine on Spring Boot 1.4.x - 2.1.x.

@snicoll
I've fixed your comment.

@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jun 19, 2018
@snicoll snicoll added this to the 2.1.0.M1 milestone Jun 19, 2018
@snicoll snicoll self-assigned this Jun 19, 2018
@snicoll snicoll changed the title Introduce the dozer-spring-boot-starter as community starter Add reference to dozer-spring-boot-starter Jun 19, 2018
snicoll pushed a commit that referenced this pull request Jun 19, 2018
@kazuki43zoo @snicoll
Add reference to dozer-spring-boot-starter
9308904 
See gh-13501
@snicoll snicoll closed this in f682c77 Jun 19, 2018
snicoll added a commit that referenced this pull request Jun 19, 2018
@snicoll
Merge pull request #13501 from kazuki43zoo:dozer
65b0daf 
* pr/13501:
  Polish "Add reference to dozer-spring-boot-starter"
  Add reference to dozer-spring-boot-starter
@kazuki43zoo kazuki43zoo deleted the dozer branch June 19, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.1.0.M1
Development

Successfully merging this pull request may close these issues.
4 participants
@kazuki43zoo @bclozel @snicoll @spring-projects-issues