Skip to content

Commit

Permalink
Set Vaadin's launch-browser property automatically
Browse files Browse the repository at this point in the history
Closes gh-1552
  • Loading branch information
mhalbritter committed Aug 16, 2024
1 parent 4aa69b4 commit 86c98ff
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import io.spring.initializr.generator.condition.ConditionalOnBuildSystem;
import io.spring.initializr.generator.condition.ConditionalOnRequestedDependency;
import io.spring.initializr.generator.project.ProjectDescription;
import io.spring.initializr.generator.spring.properties.ApplicationPropertiesCustomizer;
import io.spring.initializr.generator.spring.scm.git.GitIgnoreCustomizer;
import io.spring.initializr.metadata.InitializrMetadata;

Expand All @@ -31,6 +32,7 @@
* Configuration for generation of projects that depend on Vaadin.
*
* @author Stephane Nicoll
* @author Moritz Halbritter
*/
@Configuration(proxyBeanMethods = false)
@ConditionalOnRequestedDependency("vaadin")
Expand All @@ -54,4 +56,9 @@ GitIgnoreCustomizer vaadinGitIgnoreCustomizer() {
return (gitignore) -> gitignore.getGeneral().add("node_modules");
}

@Bean
ApplicationPropertiesCustomizer launchBrowserApplicationPropertiesCustomizer() {
return (properties) -> properties.add("vaadin.launch-browser", true);
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* Tests for {@link VaadinProjectGenerationConfiguration}.
*
* @author Stephane Nicoll
* @author Moritz Halbritter
*/
class VaadinProjectGenerationConfigurationTests extends AbstractExtensionTests {

Expand Down Expand Up @@ -110,6 +111,18 @@ void gitIgnoreWithoutVaadinDoesNotIgnoreNodeModules() {
.doesNotContain("node_modules");
}

@Test
void shouldAddLaunchBrowserProperty() {
assertThat(generateProject(createProjectRequest("vaadin"))).textFile("src/main/resources/application.properties")
.contains("vaadin.launch-browser=true");
}

@Test
void shouldNotAddLaunchBrowserPropertyIfVaadinIsNotSelected() {
assertThat(generateProject(createProjectRequest("data-jpa"))).textFile("src/main/resources/application.properties")
.doesNotContain("vaadin.launch-browser=true");
}

@Override
protected ProjectRequest createProjectRequest(String... dependencies) {
ProjectRequest request = super.createProjectRequest(dependencies);
Expand Down

0 comments on commit 86c98ff

Please sign in to comment.