Add a line separator configuration item #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update checkstyle rules so that the `NewlineAtEndOfFile` check no longer enforces only LF line separators. The default now accepts LF, CR or CRLF. Closes spring-iogh-202
Add an additional exclusion to `SpringAvoidStaticImportCheck` so that the `org.springframework.security.config.Customizer` class can be used. Closes spring-iogh-206
Update the filtering logic so that top-level file checks can also be excluded. Closes spring-iogh-210
When developing with different OS, the formatted line breaks conflict. so we need to specify the same line separator.
|
@Hccake Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Hccake Thank you for signing the Contributor License Agreement! |
Use the default when a line separator is not specified
Hccake
changed the title
philwebb
pushed a commit
that referenced
this pull request
Dec 3, 2020
Update the Maven Plugin with support for a custom line separator. See gh-212
philwebb
added a commit
that referenced
this pull request
Dec 3, 2020
philwebb
added a commit
that referenced
this pull request
Dec 3, 2020
* pr/212: Polish 'Add lineSeparator support to Maven Plugin' Add lineSeparator support to Maven Plugin
|
Thanks for the PR. I've changed it a little in commit dc18d1a to only apply the line ending change when formatting (rather than setting the global line ending system property) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing with different OS, the formatted line breaks conflict.
so we need to specify the same line separator.
This solves the issuse problem #160