Check that @TestTemplate methods are not public or private #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philwebb Given that you're the main contributor: Is there a chance this PR gets picked up? :) |
|
Yeah, sorry about the lack of action on this. I need to have a sweep of all the PRs open against this project. |
|
No worries. I was just not certain if you've seen it at all :) |
philwebb
pushed a commit
that referenced
this pull request
Dec 3, 2019
Update `SpringJUnit5Check` to check that `@TestTemplate` methods are not public or private. See gh-138
|
Thanks @dreis2211 and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when looking at some tests in Spring-Boot - e.g. EmbeddedServletContainerJarDevelopmentIntegrationTests - I was wondering if we should extend the
SpringJUnit5rule with the functionality to apply its modifier visibility checks to methods annotated with@TestTemplate. This PR is an attempt to do so.Let me know what you think.
Cheers,
Christoph