Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Eclipse 2021-06 #286

Closed
wilkinsona opened this issue Sep 24, 2021 · 2 comments
Closed

Upgrade to Eclipse 2021-06 #286

wilkinsona opened this issue Sep 24, 2021 · 2 comments

Comments

@wilkinsona
Copy link
Contributor

No description provided.

@wilkinsona wilkinsona added this to the 0.0.x milestone Sep 24, 2021
@wilkinsona wilkinsona self-assigned this Sep 24, 2021
@wilkinsona wilkinsona modified the milestones: 0.0.x, 0.0.29 Sep 24, 2021
@wilkinsona wilkinsona reopened this Sep 27, 2021
@wilkinsona
Copy link
Contributor Author

With reference to #277 (comment), 2021-06 isn't any better. In that version, it would appear that our dependencies contain a mixture of Java 8 and Java 11 bytecode. This is sufficient to allow our rewriting of DefaultCodeFormatter and NLS to succeed using Java 8-level bytecode. However, a failure still occurs at runtime due to some other dependencies using Java 11-level bytecode:

io/spring/javaformat/org/eclipse/text/edits/TextEdit has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

With the current approach at least, it appears that 2021-03 is the latest version of Eclipse that we can use without requiring command line builds to perform format checks using Java 11.

@philwebb
Copy link
Contributor

We'll try again to jump to 2021-09 in #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants