Tolerate empty lines in artifact-properties #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with action configuration in YAML:
```
artifact-properties: |
/**/*.zip::zip.name=${{ github.event.repository.name }},zip.deployed=false
/**/*docs.zip::zip.type=docs
/**/*dist.zip::zip.type=dist
```
It visually not obvious that there are some empty lines in the end.
Plus end-user may decide to separate those entries with empty lines as well.
* Fix `StringToArtifactPropertiesConverter` to use `StringUtils.hasText()`.
The `hasLength()` does count whitespaces as content
* Some other suggested by IDEA simple refactoring for the `StringToArtifactPropertiesConverter`:
- `String.split()` never returns null
- `String.substring()` without second argument yields to `length()` internally
|
And here is a result of migration to this action from my side: https://github.com/spring-io/spring-github-workflows/blob/main/.github/actions/spring-artifactory-gradle-build/action.yml#L95. |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with action configuration in YAML:
It visually not obvious that there are some empty lines in the end. Plus end-user may decide to separate those entries with empty lines as well.
Fix
StringToArtifactPropertiesConverterto useStringUtils.hasText(). ThehasLength()does count whitespaces as contentSome other suggested by IDEA simple refactoring for the
StringToArtifactPropertiesConverter:String.split()never returns nullString.substring()without second argument yields tolength()internally