Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Page Improvements #210

Closed
jzheaux opened this issue Feb 22, 2024 · 5 comments
Closed

404 Page Improvements #210

jzheaux opened this issue Feb 22, 2024 · 5 comments
Assignees

Comments

@jzheaux
Copy link

jzheaux commented Feb 22, 2024

Spring's integration with Antora produces a 404 page whose recovery links focus on Spring Security, regardless of which project is being viewed.

For example:

  1. Navigate to https://docs.spring.io/spring-ldap/reference/asdf.html and you will get a 404
  2. Click the three horizontal dots on the left to find a set of recovery links
  3. Notice that the focus seems to be on Spring Security and its set of published versions

While other projects appear on the left, it would be nice if this popup were either more generic or more directly focused on the documentation currently being visited (e.g. if I've navved to /spring-ldap/**, then I likely would be more helped by Spring LDAP links).

Additionally, there is an empty green box that could be more contextual as well; possibly it could point to the most recent documentation for that project.

@oodamien oodamien self-assigned this Mar 19, 2024
oodamien added a commit that referenced this issue Mar 19, 2024
oodamien added a commit that referenced this issue Mar 21, 2024
@oodamien
Copy link
Contributor

Fixed in #218

@philwebb
Copy link
Contributor

philwebb commented Apr 4, 2024

I still see the old 404. Does Cloudflare need busting or is it something else? https://docs.spring.io/spring-boot/missing/

@oodamien
Copy link
Contributor

oodamien commented Apr 6, 2024

It seems to be something else:
New 404: https://docs.spring.io/spring-boot/404.html
Old display: https://docs.spring.io/spring-security/404.html

@philwebb
Copy link
Contributor

https://docs.spring.io/spring-missing/missing/ also fails. Perhaps it's the httpd config?

@oodamien oodamien mentioned this issue Apr 11, 2024
@oodamien
Copy link
Contributor

Re-open on #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants