Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ivy version to 2.5.2 #619

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Update ivy version to 2.5.2 #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8587f97
Update ivy version to 2.5.2
onobc Jan 24, 2025
a289835
Add gRPC CVEs to trivyignore
onobc Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
ignore-unfixed: true
severity: 'CRITICAL,HIGH'
exit-code: 1
trivyignores: .trivyignore
- name: 'Scanned'
shell: bash
run: echo "::info ::Scanned"
Expand Down
17 changes: 16 additions & 1 deletion .trivyignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,17 @@
################################
## From debezium-supplier
################################
CVE-2023-1428
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These "mute" the grpc and protobuf related CVEs being reported

CVE-2023-32731

################################
# Snakeyaml 1.3.3
# SCDF usage has been mitigated.
################################
CVE-2022-1471
CVE-2016-1000027

################################
# Spring Web 5.3.x
# SCDF not affected.
################################
CVE-2016-1000027
4 changes: 0 additions & 4 deletions applications/processor/groovy-processor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
<relativePath>../../stream-applications-core/pom.xml</relativePath>
</parent>

<properties>
<apache-ivy.version>2.5.1</apache-ivy.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Chris, how does it work if we don’t specify version any more?
Is this Spring Boot managed dep?
So, it comes as latest now and with all those CVEs fixed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @artembilan - I was not clear in my description. We (stream-applications) already have dep. mgmt. for this ivy in stream-applications-build but for some reason these versions were still being hardcoded in these modules.
This moves those versions out of the way and lets the stream-applications-build/pom.xml be the final arbiter of the versions.

</properties>

<dependencies>

<dependency>
Expand Down
1 change: 0 additions & 1 deletion applications/processor/script-processor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<properties>
<jruby-complete.version>9.3.9.0</jruby-complete.version>
<jython-standalone.version>2.7.3</jython-standalone.version>
<apache-ivy.version>2.5.1</apache-ivy.version>
<graalvm.version>22.3.0</graalvm.version>
</properties>

Expand Down
1 change: 0 additions & 1 deletion scan-jar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ SCDIR=$(realpath $SCDIR)
if [[ "$1" != *"-sources.jar" ]] && [[ "$1" != *"-javadoc.jar" ]]; then
if [ "$TRIVY_UPLOAD" == "true" ]; then
echo "Scanning:$1"
echo "trivy rootfs --format sarif -o \"$1.sarif\" \"$1\""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like some debug that is surely to get out of sync w/ the actual command

trivy rootfs --exit-code 1 --format sarif -o "$1.sarif" "$1"
if [ -f "$1.sarif" ]; then
if [ -f $SCDIR/runs.sarif ]; then
Expand Down