Fix "Description in the doc is wrong"(#318) #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update about this? |
Pengfei-Lu
force-pushed
the
doc-optimization
branch
from
1cd9e61 to
0beca95
Compare
|
Any update about this? @spencergibb |
Pengfei-Lu
force-pushed
the
doc-optimization
branch
from
0beca95 to
f193b8b
Compare
|
I've fix the conflicts with the main branch. Please check. @OlgaMaciaszek |
OlgaMaciaszek
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Thanks @Pengfei-Lu . Sending a HTTP POST request to /refresh also works. Please update your change to include it.
@OlgaMaciaszek I've updated the change. Please check. Thanks. |
OlgaMaciaszek
requested changes
Oct 11, 2023
There was a problem hiding this comment.
Thanks @Pengfei-Lu. I have added a comment. Please address.
docs/modules/ROOT/pages/config.adoc
Outdated
| @@ -25,7 +25,7 @@ only to the instances of the service named `testApp`. | |||
|
|
|||
| Configuration is currently read on startup of the application. Sending a HTTP `POST` | |||
| request to `/refresh` causes the configuration to be reloaded. Watching the configuration | |||
| namespace (which Zookeeper supports) is not currently implemented. | |||
| namespace (which Zookeeper supports) is currently implemented also. | |||
There was a problem hiding this comment.
Please change from "is currently implemented also." to "is also available.".
There was a problem hiding this comment.
Done. Please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #318