Manage the version of okhttp in commons (#1470)

spring-cloud · Feb 14, 2025 · 1239566 · 1239566
1 parent c8cade1
commit 1239566
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/spring-cloud-commons-dependencies/pom.xml b/spring-cloud-commons-dependencies/pom.xml
@@ -15,6 +15,7 @@
 	<name>spring-cloud-commons-dependencies</name>
 	<description>Spring Cloud Commons Dependencies</description>
 	<properties>
+		<okhttp.version>4.12.0</okhttp.version>
 	</properties>
 	<dependencyManagement>
 		<dependencies>
@@ -53,6 +54,20 @@
 				<artifactId>spring-cloud-test-support</artifactId>
 				<version>${project.version}</version>
 			</dependency>
+			<!-- Spring Boot removed its dependency management of okhttp in Spring Boot 3.4.0 -->
+			<!-- This resulted in a different version fo okhttp in Spring Cloud 2024.0.0 -->
+			<!-- We will now manage the version in Spring Cloud Commons to maintain backward compatibility -->
+			<!-- This can be removed in the next major -->
+			<dependency>
+				<groupId>com.squareup.okhttp3</groupId>
+				<artifactId>okhttp</artifactId>
+				<version>${okhttp.version}</version>
+			</dependency>
+			<dependency>
+				<groupId>com.squareup.okhttp3</groupId>
+				<artifactId>logging-interceptor</artifactId>
+				<version>${okhttp.version}</version>
+			</dependency>
 		</dependencies>
 	</dependencyManagement>
 	<profiles>

diff --git a/spring-cloud-commons/pom.xml b/spring-cloud-commons/pom.xml
@@ -176,6 +176,16 @@
 			<artifactId>httpclient5</artifactId>
 			<optional>true</optional>
 		</dependency>
+		<dependency>
+			<groupId>com.squareup.okhttp3</groupId>
+			<artifactId>okhttp</artifactId>
+			<optional>true</optional>
+		</dependency>
+		<dependency>
+			<groupId>com.squareup.okhttp3</groupId>
+			<artifactId>logging-interceptor</artifactId>
+			<optional>true</optional>
+		</dependency>
 		<dependency>
 			<groupId>org.springframework.boot</groupId>
 			<artifactId>spring-boot-starter-test</artifactId>