Removing stack assertion in ATs #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albertoimpl
commented
Mar 6, 2024
...c/test/java/org/springframework/cloud/appbroker/acceptance/CreateInstanceAcceptanceTest.java
Show resolved
Hide resolved
Albertoimpl
commented
Mar 6, 2024
...va/org/springframework/cloud/appbroker/acceptance/CreateInstanceWithStackAcceptanceTest.java
Outdated
Show resolved
Hide resolved
Albertoimpl
force-pushed
the
arios/22x-default-cflinuxfs4
branch
2 times, most recently
from
a7da861 to
d034019
Compare
Albertoimpl
changed the title
Moving al references to cflinuxfs3
Albertoimpl
force-pushed
the
arios/22x-default-cflinuxfs4
branch
from
d034019 to
3e198f6
Compare
|
Since we have an integration test that covers that the stack is being passed to the platform, I don't think we are loosing much from not checking that the stack changes. |
spikymonkey
approved these changes
Mar 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all references from cflinuxfs3 to cflinuxfs4.
Most of the cf deployments don't have any other stack aside from cflinuxfs4, moved the assertions to check on 4.