Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(1.6.x): Updating wiremock to a java8 compatible version #846

Merged
merged 1 commit into from
Sep 6, 2023
Merged

(1.6.x): Updating wiremock to a java8 compatible version #846

merged 1 commit into from
Sep 6, 2023

Conversation

Albertoimpl
Copy link
Member

No description provided.

@Albertoimpl Albertoimpl mentioned this pull request Sep 6, 2023
Closed
@Albertoimpl Albertoimpl changed the title 1.6.x Updating wiremock to a java8 compatible version (1.6.x) Updating wiremock to a java8 compatible version Sep 6, 2023
@Albertoimpl Albertoimpl changed the title (1.6.x) Updating wiremock to a java8 compatible version (1.6.x): Updating wiremock to a java8 compatible version Sep 6, 2023
abelsromero
abelsromero approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@abelsromero abelsromero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving only to run CI

@Albertoimpl Albertoimpl force-pushed the arios/16x-wiremock-3-java-8 branch from 37c486b to 7451df0 Compare September 6, 2023 09:16
@abelsromero
Copy link
Contributor

Should we also delete dependabot from this branch and update the one in main to prevent bumps? I can see myself wondering in 1 month why 3.0.2 is failing 😅

@Albertoimpl
Copy link
Member Author

Dependabot only gets triggered from what is on dependabot.yml in main if I remember correctly.
I am adding these lines in main too:

      - dependency-name: "com.github.tomakehurst:wiremock-jre8-standalone"
        update-types:
          - "version-update:semver-minor"
          - "version-update:semver-patch"

@Albertoimpl Albertoimpl merged commit 9806be5 into 1.6.x Sep 6, 2023
@Albertoimpl Albertoimpl deleted the arios/16x-wiremock-3-java-8 branch September 6, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelsromero abelsromero abelsromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Albertoimpl @abelsromero