Adding platform timeout configuration #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albertoimpl
force-pushed
the
arios/configure-default-platform-timeouts
branch
from
25ce614 to
d8da646
Compare
kvmw
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I verified the snapshot build and is working as expected. Thank you!
The only minor suggestion I have is a message for the failure, If possible.
Currently, the SI status is shown like the following, in case of timeout error:
Showing status of last operation:
status: update failed
message:
started: 2024-09-26T14:04:45Z
updated: 2024-09-26T14:04:45Z
Maybe having a message like "timeout waiting for deployment" or such can help users without the need to check the logs.
spring-cloud-app-broker-docs/src/docs/asciidoc/deployment-platforms.adoc
Outdated
Show resolved
Hide resolved
Albertoimpl
force-pushed
the
arios/configure-default-platform-timeouts
branch
from
d8da646 to
80c2a01
Compare
|
Thanks for testing it @kvmw! I like your suggestion regarding error messages but it would require a different set of changes. Mind filing a new issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.