(2.3.x): Adding logging module using LogCacheClient #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albertoimpl
changed the title
Albertoimpl
force-pushed
the
arios/adding-cf-logging
branch
from
dd41713 to
e7bd5d6
Compare
kvmw
approved these changes
Jul 8, 2024
spikymonkey
requested changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks @Albertoimpl, this looks like it was a lot of work! I found a few things but nothing major. Happy to chat through any of the comments so we can get this merged in asap 👏
...src/test/java/org/springframework/cloud/appbroker/acceptance/CloudFoundryAcceptanceTest.java
Show resolved
Hide resolved
...src/test/java/org/springframework/cloud/appbroker/acceptance/CloudFoundryAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/springframework/cloud/appbroker/acceptance/CloudFoundryAcceptanceTest.java
Show resolved
Hide resolved
...rc/test/java/org/springframework/cloud/appbroker/acceptance/LoggingRecentAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/springframework/cloud/appbroker/acceptance/LoggingRecentAcceptanceTest.java
Show resolved
Hide resolved
...main/java/org/springframework/cloud/appbroker/logging/streaming/LogCacheStreamPublisher.java
Show resolved
Hide resolved
...main/java/org/springframework/cloud/appbroker/logging/streaming/LogCacheStreamPublisher.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/appbroker/logging/streaming/LogCacheStreamPublisher.java
Outdated
Show resolved
Hide resolved
...springframework/cloud/appbroker/logging/streaming/endpoint/StreamingLogWebSocketHandler.java
Outdated
Show resolved
Hide resolved
...springframework/cloud/appbroker/logging/streaming/endpoint/StreamingLogWebSocketHandler.java
Outdated
Show resolved
Hide resolved
…ingframework/cloud/appbroker/acceptance/LoggingRecentAcceptanceTest.java Co-authored-by: Gareth Clay <[email protected]>
…ork/cloud/appbroker/logging/streaming/LogCacheStreamPublisher.java Co-authored-by: Gareth Clay <[email protected]>
…ingframework/cloud/appbroker/acceptance/LoggingStreamingAcceptanceTest.java Co-authored-by: Gareth Clay <[email protected]>
…ork/cloud/appbroker/logging/streaming/endpoint/StreamingLogWebSocketHandler.java Co-authored-by: Gareth Clay <[email protected]>
…ingframework/cloud/appbroker/acceptance/fixtures/cf/CloudFoundryService.java Co-authored-by: Gareth Clay <[email protected]>
…ork/cloud/appbroker/logging/streaming/LogCacheStreamPublisher.java Co-authored-by: Gareth Clay <[email protected]>
Albertoimpl
force-pushed
the
arios/adding-cf-logging
branch
from
3a7f80e to
9c6af34
Compare
spikymonkey
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Finishes #995]