Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Make Secret Manager Configuration conditional on Secret Manager Library #2507

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Aug 27, 2020

The Secret Manager autoconfiguration should only be activated if the Spring Cloud GCP Secret Manager library is added on the classpath. This makes the change.

Fixes #2506.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #2507 into master will decrease coverage by 7.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2507      +/-   ##
============================================
- Coverage     81.43%   74.21%   -7.23%     
+ Complexity     2382     2156     -226     
============================================
  Files           267      267              
  Lines          7736     7737       +1     
  Branches        798      799       +1     
============================================
- Hits           6300     5742     -558     
- Misses         1098     1626     +528     
- Partials        338      369      +31     
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.21% <ø> (+<0.01%) 2156.00 <ø> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...anager/GcpSecretManagerBootstrapConfiguration.java 65.00% <ø> (-5.00%) 3.00 <0.00> (-1.00)
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 141ba77...16904af. Read the comment docs.

@dzou dzou merged commit 79f0f1e into master Aug 27, 2020
@dzou dzou deleted the make-sm-autoconfig-conditional branch August 27, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Spring boot error when using google-cloud-secretmanager library without spring-cloud-gcp-starter-secretmanager
3 participants