-
Notifications
You must be signed in to change notification settings - Fork 14
Add urldecode checkbox #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add urldecode checkbox #271
Conversation
Thank you for your contribution! I've tried your changes and it appears to only decode some characters?
So the On the other hand, this is only in the frontend so you cannot search in urldecoded data. Maybe a converter similar to the base64 one would be nice? |
|
||
if (props.urlDecode) { | ||
try { | ||
chunkData = decodeURI(chunkData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we want decodeURIComponent
?
Thank you for your reply! I will look into why it may not be working as expected. You're right, using |
We html encode all printable ascii characters. Unicode characters are inserted verbatim now which feels bad. Is there some homoglyphing possible in html? :D Maybe html encode them too? |
I don't think urldecoding and interpreting the resulting bytes as unicode have to be tied to one step. You can just return the "raw" urldecoded bytes? |
Can you split the addition of unicode decoding into a separate pull request please? I feel this is piggy-backing on to this change and appears unrelated and worth further discussion. |
Add
URL Decode
checkbox for the ASCII view.This change allows toggling URL decoding for the ASCII view. Also, update the
inlineAscii
processing function to display UTF-8 symbols properly — for example, when the server sends escaped Unicode characters.