Add stopWithFlush option to ffwd reporter & ffwd http reporter #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irock
reviewed
Jan 7, 2021
| if (executorOwner) { | ||
| executorService.shutdown(); | ||
| } | ||
| //final flush of metrics |
There was a problem hiding this comment.
I wonder if the log line might be sufficient documentation for what's going on.
irock
reviewed
Jan 7, 2021
| registry.derivingMeter(MetricId.build("deriving-meter")); | ||
|
|
||
|
|
irock
reviewed
Jan 7, 2021
|
|
||
| @Test | ||
| public void someReportingNoTickFails() { |
There was a problem hiding this comment.
I'm not sure best description is that it fails? Perhaps a more descriptive name could be noReportingIfNoTick?
hexedpackets
approved these changes
Jan 7, 2021
irock
approved these changes
Jan 8, 2021
lmuhlha
changed the title
malish8632
approved these changes
Jan 8, 2021
hexedpackets
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stop with flush option for user's who would like to ensure a final flush of metrics when their service shuts down.
Tests for: