Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use original key value to report counter within reportMetered, add test #102

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Use original key value to report counter within reportMetered, add test #102

merged 1 commit into from
Feb 11, 2021

Conversation

lmuhlha
Copy link
Member

@lmuhlha lmuhlha commented Feb 8, 2021 •
edited
Loading

#101
Before:
Screen Shot 2021-02-08 at 4 42 42 PM
After, test passes for

List<String> expectedKeys = Arrays.asList("test.hi", "test.thename", "test.thename",
        "test.thename", "test.hi", "test.thename", "test.thename", "test.thename");

@lmuhlha lmuhlha force-pushed the prefix branch 2 times, most recently from fc78149 to fe9292e Compare February 8, 2021 21:49
@lmuhlha lmuhlha changed the title Use original key value to report counter within reportMetered Use original key value to report counter within reportMetered, add test Feb 8, 2021
@lmuhlha lmuhlha requested a review from a team February 8, 2021 21:50
@lmuhlha lmuhlha mentioned this pull request Feb 8, 2021
Closed
@lmuhlha lmuhlha force-pushed the prefix branch 2 times, most recently from f1a576a to e8de96d Compare February 8, 2021 23:19
@lmuhlha lmuhlha merged commit 313d3a9 into master Feb 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the prefix branch February 11, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malish8632 malish8632 malish8632 approved these changes

@mattnworb mattnworb mattnworb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmuhlha @mattnworb @malish8632