Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lib] limit apache-beam version <2.25.0 #107

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Conversation

DanSimon
Copy link
Contributor

@DanSimon DanSimon commented Oct 26, 2020

2.25.0 has transitive dependencies that cause conflicts:

google-cloud-build 2.0.0 has requirement google-api-core[grpc]<2.0.0dev,>=1.22.0, but you have google-api-core 1.20.1.
google-cloud-bigquery 1.28.0 has requirement google-api-core<2.0dev,>=1.21.0, but you have google-api-core 1.20.1.

Also, 2.25.0 has changed BigQuerySource from a class to a function, and since we have classes that inherit from it, Klio is currently incompatible with it.

Checklist for PR author(s)

  • Format the pull request title like [cli] Fixes bugs in 'klio job fake-cmd'.
  • Changes are covered by unit tests (no major decrease in code coverage %) and/or integration tests.
  • Document any relevant additions/changes in the appropriate spot in docs/src.

Copy link
Contributor

@fallonchen fallonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DanSimon DanSimon merged commit 99d5f30 into master Oct 27, 2020
@DanSimon DanSimon deleted the dsimon/limit-beam-version branch October 27, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants