This repository has been archived by the owner on Mar 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Implement new Bigtable timeout & retry settings #733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Kingswell <[email protected]>
- passing all tests - next is to refactor the 5 parameters into a class Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
malish8632
approved these changes
Dec 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
so that they're not repeated several times over Signed-off-by: Peter Kingswell <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
============================================
+ Coverage 55.09% 55.20% +0.10%
- Complexity 3163 3175 +12
============================================
Files 749 751 +2
Lines 20427 20544 +117
Branches 1341 1343 +2
============================================
+ Hits 11254 11341 +87
- Misses 8684 8716 +32
+ Partials 489 487 -2
Continue to review full report at Codecov.
|
sming
commented
Dec 22, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableMetricModule.java
Show resolved
Hide resolved
sming
commented
Dec 22, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableMetricModule.java
Show resolved
Hide resolved
Signed-off-by: Peter Kingswell <[email protected]>
lmuhlha
reviewed
Dec 22, 2020
heroic-component/src/main/java/com/spotify/heroic/metric/consts/ApiQueryConsts.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Dec 22, 2020
heroic-component/src/main/java/com/spotify/heroic/metric/consts/ApiQueryConsts.java
Outdated
Show resolved
Hide resolved
malish8632
previously approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
adsail
previously approved these changes
Dec 22, 2020
lmuhlha
reviewed
Dec 22, 2020
metric/bigtable/src/main/java/com/spotify/heroic/metric/bigtable/BigtableConnectionBuilder.java
Show resolved
Hide resolved
Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
and localhost IT test runs where it works locally but not in CI. Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
Signed-off-by: Peter Kingswell <[email protected]>
down the road all tests of this kind (timer-based) will need redoing as they're lame and brittle. Signed-off-by: Peter Kingswell <[email protected]>
to prevent the intermittent timeouts that are being observed.
…tings-refactored' into feature/add-bigtable-timeout-settings-refactored
build intermittently failing on com.spotify.heroic.AbstractClusterQueryIT distributedFilterQueryTest - investigating.
- occurred when a timeout happened - full message: java.lang.IllegalStateException: Could not find policy 'pick_first'. Make sure its implementation is either registered to LoadBalancerRegistry or included in META-INF/services/io.grpc.LoadBalancerProvider from your jar files.
adsail
reviewed
Mar 1, 2021
rpc/grpc/src/main/java/com/spotify/heroic/rpc/grpc/GrpcRpcProtocolServer.java
Show resolved
Hide resolved
settings. tidied up docs too
adsail
previously approved these changes
Mar 2, 2021
malish8632
previously approved these changes
Mar 3, 2021
adsail
approved these changes
Mar 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Case Resolved: Heroic pipeline instability and poor user experience for Grafana
Plan
Notes for Reviewer
mutateRpcTimeoutMs
back to 10 minutes.