Update byte-buddy to 1.10.20 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Java 15 support, and better integration with Mockito.
rydenius
approved these changes
May 10, 2021
There was a problem hiding this comment.
Thank you. Linking https://spotify.slack.com/archives/CM5CTDU07/p1620641145093300 here too for additional context.
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| # test against latest update of each major Java version, as well as specific updates of LTS versions: | |||
| java: [ 8, 11, 13 ] | |||
| java: [ 8, 11, 13, 15 ] | |||
There was a problem hiding this comment.
According to the comment above I would have expected 15 to replace 13 rather than getting appended? But this works too of course.
There was a problem hiding this comment.
Don't really have a fully thought-out strategy here, but went with both 13 and 15 as they are MTS releases on some distros (e.g. Azul https://www.azul.com/products/azul-support-roadmap/). Once 17 gets released, I would imagine we would remove 13 and 15.
mattnworb
approved these changes
May 10, 2021
spkrka
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Java 15 support, and better integration with Mockito.