Prevent growing metrics cardinality #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol7
approved these changes
Apr 30, 2021
mattnworb
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Great idea.
Did you think about what happens when there are thread names like pool-4-thread-1 and pool-11-thread-2? They'd sanitize to the same string which could make it hard to identify which has blocking calls, but then again perhaps that's a sign that you should give the pools actual names.
Also how about adding something to the README about this behavior?
spkrka
force-pushed
the
krka/threadname2
branch
from
b76ade2 to
ffbc30f
Compare
|
Thanks @mattnworb , pushed an update to the README |
We can have an infinitely growing set of thread names that have been used by the JVM. By replacing all numbers with a constant character, we can minimize that problem, since thread pools typically use counters when creating new threads.
spkrka
force-pushed
the
krka/threadname2
branch
from
ffbc30f to
d850906
Compare
mattnworb
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have an infinitely growing set of thread names that have
been used by the JVM. By replacing all numbers with a
constant character, we can minimize that problem, since thread pools
typically use counters when creating new threads.