-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
88f3228
to
67f4810
Compare
Overall looks good to me. |
d27b942
to
c9a1a05
Compare
d9b76f2
to
76e42fd
Compare
I opted for breaking the API. The motivation is that it is still quite early in the project and to me the async should be default. |
LGTM 👍 |
other notable changes: - reduce dependencies: guava, apollo - clean up things not properly cleaned up before
b96cb55
to
2d1fc62
Compare
this.future = future; | ||
} | ||
|
||
public Future<T> future() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why Future
(which only allows blocking get()
) instead of CompletableFuture
or CompletionStage
?
Result
object rather than callSystem.exit
(replaced byFloRunner.runTask(foo).waitAndExit()
)TaskConstructor
interface which was used mostly for CLI usage