Skip to content
This repository was archived by the owner on Aug 31, 2022. It is now read-only.

Be able to pass success to BigQueryOperation #209

Closed
wants to merge 1 commit into from
Closed

Be able to pass success to BigQueryOperation #209

wants to merge 1 commit into from

Conversation

wscheep
Copy link

@wscheep wscheep commented Nov 12, 2019 •
edited
Loading

Hey, I just made a Pull Request!

Add a public method to pass a success function to a BigQueryOperation.
Solves #208.

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@narape
Copy link
Contributor

narape commented Nov 12, 2019

We decided to close this PR in favor of #210

@narape narape closed this Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wscheep @narape