This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Shading tolerant version reading #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnorberg
force-pushed
the
shading-tolerant-version-reading
branch
from
9175cc9 to
cacbdc9
Compare
NatashaL
reviewed
Dec 5, 2018
| } | ||
|
|
||
| private static String readFloRunnerVersion() { | ||
| final String resource = "/com/spotify/flo/flo-runner.version"; |
There was a problem hiding this comment.
If flo is shaded won't this path be different then?
There was a problem hiding this comment.
If it is relocated yes, but the shading plugin then also updates this string to reflect that. Added tests for that.
NatashaL
reviewed
Dec 5, 2018
| public void shouldReadFloVersion() throws IOException { | ||
| final String expectedVersion; | ||
| try (final BufferedReader reader = new BufferedReader(new InputStreamReader( | ||
| Version.class.getResourceAsStream("/com/spotify/flo/flo-runner.version")))) { |
There was a problem hiding this comment.
The test should never be shaded.
|
Other than the test failing due to memory, this looks good to me 👍 |
|
Tried a fix here #198 although not sure if it's the best approach. @danielnorberg ptal |
danielnorberg
force-pushed
the
shading-tolerant-version-reading
branch
from
9791113 to
8f15261
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Shading tolerant version reading
Motivation and Context
If users (e.g. MC) shades flo-runner, we currently log an incorrect flo runner version.
Have you tested this? If so, how?
Checklist for PR author(s)
Checklist for PR reviewer(s)