Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default type test #474

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix default type test #474

merged 1 commit into from
Oct 6, 2022

Conversation

elanv
Copy link
Contributor

@elanv elanv commented Oct 6, 2022

There were some things missing from the previous commits.
Improved type defaulting test to check if the fetched value matches the expected value.

@regadas Could you review this too? Thanks!

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope! Thanks!

@regadas regadas merged commit b4cdfd0 into spotify:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants