Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component checks for cluster update and taskmanager deployments. #464

Merged
merged 4 commits into from
Oct 7, 2022
Merged

Fix component checks for cluster update and taskmanager deployments. #464

merged 4 commits into from
Oct 7, 2022

Conversation

kocomic
Copy link
Contributor

@kocomic kocomic commented Sep 9, 2022

No description provided.

regadas
regadas reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this looks good!

regadas
regadas approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kocomic I went ahead and did the nits 🎨

@regadas regadas merged commit dc9a2b1 into spotify:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocomic @regadas