Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce kubebuilder markers for type validation/defaulting #449

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Introduce kubebuilder markers for type validation/defaulting #449

merged 2 commits into from
Oct 5, 2022

Conversation

elanv
Copy link
Contributor

@elanv elanv commented Aug 12, 2022 •
edited
Loading

Introduce kubebuilder markers for types.

Advantages:

  • Reduces webhook code writing (default/validating)
  • Improve readability
  • Leverage k8s API server and reduce operator custom webhook dependece.
  • Make local development easier (reduce manifest writing for default values (related to local deployment issues of webhooks)

@elanv elanv marked this pull request as ready for review August 12, 2022 18:10
regadas
regadas approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elanv apologies for the late late review here! this looks great thank you!

@regadas regadas merged commit 223b2dc into spotify:master Oct 5, 2022
@regadas regadas mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elanv @regadas