Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TaskManager deployment through Deployment resource #410

Merged
merged 14 commits into from
Jun 2, 2022
Merged

Add TaskManager deployment through Deployment resource #410

merged 14 commits into from
Jun 2, 2022

Conversation

live-wire
Copy link
Contributor

This change will allow a significantly faster startup time for batch workloads with high number of replicas

@live-wire live-wire changed the title Ephemeral taskmanager deployment WIP: Ephemeral taskmanager deployment May 30, 2022
regadas
regadas reviewed Jun 1, 2022
View reviewed changes
internal/model/model.go Outdated Show resolved Hide resolved
regadas
regadas reviewed Jun 1, 2022
View reviewed changes
internal/model/model.go Outdated Show resolved Hide resolved
@live-wire live-wire force-pushed the live-wire/ephemeral branch from d54f057 to 9fef96b Compare June 1, 2022 12:52
@jto
Copy link
Contributor

jto commented Jun 1, 2022 •
edited
Loading

This looks great! Could you add a couple of tests for the new type of deployment ?

@live-wire
Copy link
Contributor Author

I'm done with the suggested changes.
Any more improvements @jto @regadas ?

@live-wire live-wire changed the title WIP: Ephemeral taskmanager deployment Ephemeral taskmanager deployment Jun 1, 2022
regadas
regadas requested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just a few comments and I think we are good to go.

apis/flinkcluster/v1beta1/flinkcluster_types.go Outdated Show resolved Hide resolved
apis/flinkcluster/v1beta1/flinkcluster_types.go Outdated Show resolved Hide resolved
apis/flinkcluster/v1beta1/flinkcluster_types.go Outdated Show resolved Hide resolved
controllers/flinkcluster/flinkcluster_util.go Outdated Show resolved Hide resolved
controllers/flinkcluster/flinkcluster_observer.go Outdated Show resolved Hide resolved
apis/flinkcluster/v1beta1/flinkcluster_types.go Outdated Show resolved Hide resolved
@regadas regadas changed the title Ephemeral taskmanager deployment Add TaskManager deployment through Deployment resource Jun 2, 2022
@live-wire
Copy link
Contributor Author

Done! @regadas
Let's 🚢 it?

@live-wire live-wire requested a review from regadas June 2, 2022 13:52
@regadas regadas merged commit ee9d70a into master Jun 2, 2022
@regadas regadas deleted the live-wire/ephemeral branch June 2, 2022 14:21
@regadas
Copy link
Contributor

regadas commented Jun 2, 2022

@live-wire triggered a release v0.4.1-beta.3 for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jto jto jto left review comments

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Taskmanager ephemeral Deployment instead of Statefulset
3 participants
@live-wire @jto @regadas