Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classpath parameter support #388

Merged
merged 1 commit into from
May 11, 2022
Merged

Add classpath parameter support #388

merged 1 commit into from
May 11, 2022

Conversation

jto
Copy link
Contributor

@jto jto commented May 5, 2022

Add support for the -C parameter from Flink CLI

@jto jto merged commit 018ec74 into master May 11, 2022
@regadas regadas deleted the julien/add-classpath branch May 11, 2022 13:54
@@ -671,6 +671,12 @@ func newJobSubmitterPodSpec(flinkCluster *v1beta1.FlinkCluster) *corev1.PodSpec
jobArgs = append(jobArgs, "--detached")
}

if jobSpec.ClassPath != nil && len(jobSpec.ClassPath) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 we could skip this check since the default value is an empty list already 🤷

@regadas
Copy link
Contributor

regadas commented May 11, 2022

This is cool we need to regen the docs though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants