Update beam example cluster yaml #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add required spec.flinkVersion Remove resources so that default values will be used
regadas
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Thanks for this @chajath!
Part of me likes that jobManager/taskManager resources are being called out; works as documentation.
What do you think of creating a separate example that uses just the defaults and call it out as comments?
regadas
approved these changes
Apr 4, 2022
|
Thanks for the review and merge. I still can't get the job server version working out of box. If I figure out, I'll open a follow up PR. Will also throw in some comments here and there if I get the chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing yaml files fails because of missing flinkVersion and resources cpu limit not defined.
Add required spec.flinkVersion
Remove resources so that default values will be used