Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Golang 1.18 #333

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Upgrade to Golang 1.18 #333

merged 5 commits into from
Apr 4, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Mar 18, 2022

as #325

regadas
regadas reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @haoxins;

What was the reason behind the change of the Makefile?

@haoxins
Copy link
Contributor Author

haoxins commented Mar 25, 2022

the go get is deprecated for Go 1.18, replaced with go install

@regadas
Copy link
Contributor

regadas commented Mar 25, 2022

gotcha but why not just change this line?

GOBIN=$(PROJECT_DIR)/bin go get $(2)

@haoxins
Copy link
Contributor Author

haoxins commented Mar 26, 2022

gotcha but why not just change this line?

GOBIN=$(PROJECT_DIR)/bin go get $(2)

updated

regadas
regadas approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @haoxins; I reverted the Makefile coz it's working ok and I postponed the any type change. Hope you don't mind 🙏

@regadas regadas merged commit 5255fac into spotify:master Apr 4, 2022
@haoxins haoxins deleted the chore-go-118 branch April 4, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoxins @regadas