Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value for log4j-cli.properties in ConfigMap addresses (#315) #316

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Add default value for log4j-cli.properties in ConfigMap addresses (#315) #316

merged 1 commit into from
Mar 7, 2022

Conversation

JSchulte01
Copy link
Contributor

No description provided.

@JSchulte01 JSchulte01 changed the title Add default value for log4j-cli.properties in ConfigMap and update tests Add default value for log4j-cli.properties in ConfigMap addresses (#315) Mar 5, 2022
@JSchulte01
Copy link
Contributor Author

Address #315

regadas
regadas reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JSchulte01

@regadas regadas merged commit cc0db02 into spotify:master Mar 7, 2022
@JSchulte01 JSchulte01 deleted the add-default-log4j-cli branch March 7, 2022 11:34
@regadas regadas mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSchulte01 @regadas