Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix comments #311

Merged
merged 2 commits into from
Mar 7, 2022
Merged

chore: fix comments #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22b5ca8
chore: fix comments
haoxins Mar 4, 2022
c932288
comments typo
haoxins Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/flinkcluster/flinkcluster_converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,15 +843,15 @@ func appendEnvVars(envVars []corev1.EnvVar, newEnvVars ...corev1.EnvVar) []corev
return envVars
}

// Copy any non-duplicate volume mounts and env vars to the specified containers
// Copy any non-duplicate volume mounts and env vars to each specified container
func convertContainer(container corev1.Container, volumeMounts []corev1.VolumeMount, envVars []corev1.EnvVar) corev1.Container {
container.VolumeMounts = appendVolumeMounts(container.VolumeMounts, volumeMounts...)
container.Env = appendEnvVars(container.Env, envVars...)

return container
}

// Copy any non-duplicate volume mounts and env vars to each specified container
// Copy any non-duplicate volume mounts and env vars to the specified containers
func convertContainers(containers []corev1.Container, volumeMounts []corev1.VolumeMount, envVars []corev1.EnvVar) []corev1.Container {
var updatedContainers = []corev1.Container{}
for _, container := range containers {
Expand Down
4 changes: 2 additions & 2 deletions controllers/flinkcluster/flinkcluster_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func getFlinkAPIBaseURL(cluster *v1beta1.FlinkCluster) string {
*cluster.Spec.JobManager.Ports.UI)
}

// Gets JobManager ingress name
// Gets ConfigMap name
func getConfigMapName(clusterName string) string {
return clusterName + "-configmap"
}
Expand All @@ -112,7 +112,7 @@ func getJobManagerIngressName(clusterName string) string {
return clusterName + "-jobmanager"
}

// Gets TaskManager name
// Gets TaskManager StatefulSet name
func getTaskManagerStatefulSetName(clusterName string) string {
return clusterName + "-taskmanager"
}
Expand Down