New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiple Helm chart fixes #310

Merged

regadas merged 4 commits into spotify:master from Sudokamikaze:helm-chart-fixes

Mar 7, 2022

Contributor

Sudokamikaze commented Mar 3, 2022

In this PR, I fixed multiple issues I stumbled across when I was trying to deploy this project:

Fix for ignoring watchNamespace
Fix for creating SA in proper namespace, without it, replicaset won't be able to create any operator replicas, due to error of finding SA
Fix for mounting secret "cert" as volume, without using proper SA name, it won't be able to find it even if it's in a correct NS
Little grammar fix

Sudokamikaze added 4 commits

March 3, 2022 19:05


          Fix ignored watchNamespace in Helm template flink-operator

1dee65a


          Fix minor grammar mistake in Helm values

d126268


          Create SA in proper namespace defined in Values

c8cabec


          Use proper name of SA when generating certs

8ce413f

regadas approved these changes

View reviewed changes

Contributor

regadas left a comment

This is great! Thanks @Sudokamikaze

regadas merged commit 1967e49 into spotify:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet