Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default container annotation for deployment #300

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Add default container annotation for deployment #300

merged 2 commits into from
Mar 8, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Feb 28, 2022 •
edited
Loading

easier for kubectl logs

regadas
regadas reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add this also to https://github.com/spotify/flink-on-k8s-operator/blob/master/config/manager/manager.yaml

@haoxins
Copy link
Contributor Author

haoxins commented Mar 8, 2022

I think we can add this also to https://github.com/spotify/flink-on-k8s-operator/blob/master/config/manager/manager.yaml

added also

@regadas regadas merged commit b939063 into spotify:master Mar 8, 2022
@haoxins haoxins deleted the chore-add-default-container-for-op branch March 9, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regadas regadas regadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoxins @regadas