Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify container name "main" to account for sidecar containers #205

Merged
merged 1 commit into from
Jan 13, 2022
Merged

specify container name "main" to account for sidecar containers #205

merged 1 commit into from
Jan 13, 2022

Conversation

jaredstehler
Copy link
Contributor

When running with injected sidecars (i.e. istio-proxy) pod.GetLogs requires a container name to be specified.

From https://pkg.go.dev/k8s.io/api/core/v1#PodLogOptions:

type PodLogOptions struct {
	metav1.TypeMeta `json:",inline"`

	// The container for which to stream logs. Defaults to only container if there is one container in the pod.
	// +optional
	Container string `json:"container,omitempty" protobuf:"bytes,1,opt,name=container"`

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaredstehler !

@regadas regadas merged commit b71d0dc into spotify:master Jan 13, 2022
wseaton pushed a commit to wseaton/flink-on-k8s-operator that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants