This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Remove unused DockerDateFormat #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @spotify/docker-admins |
mattnworb
approved these changes
Sep 24, 2018
|
Not sure. @rculbertson, I see you wrote these lines. Do you know? |
davidxia
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
============================================
+ Coverage 67.08% 67.31% +0.23%
- Complexity 789 794 +5
============================================
Files 178 178
Lines 3287 3286 -1
Branches 385 385
============================================
+ Hits 2205 2212 +7
+ Misses 917 911 -6
+ Partials 165 163 -2 |
This library was originally using Java 7. Java 7 had `Date` objects with only millisecond precision. This was a problem when translating timestamps with nanosecond precision from the Docker API to `Date`. This library is on Java 8 now whose `Date` translates a timestamp with nanosecond precision correctly. Removing `DockerDateFormat` fixes the findbugs error here #1068. See build logs https://travis-ci.org/spotify/docker-client/jobs/426781589.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library was originally using Java 7. Java 7 had
Dateobjectswith only millisecond precision.
This was a problem when translating timestamps with nanosecond
precision from the Docker API to
Date.This library is on Java 8 now whose
Datetranslates a timestamp withnanosecond precision correctly.
Removing
DockerDateFormatfixes the findbugs error here#1068.
See build logs https://travis-ci.org/spotify/docker-client/jobs/426781589.