add Automatic-Module-Name to JAR #85
Conversation
If the JAR for this repo is used in a project where the module system is
active, Java treats any "plain JAR" without a module descriptor as an
"automatic module" and allows it to be used by other modules in the
application.
For instance, a module in an application using JPMS can depend on this
project like
```
module com.mattnworb.jpms {
requires com.spotify.completablefutures;
}
```
Defining an `Automatic-Module-Name` allows for explicitly controlling
the name that modules use when loading your automatic module, rather
JPMS guessing at the automatic module name for the JAR based on the
JAR's filename.
Alternatively we could add a `module-info.java` to this project to
enable it to be loaded as a regular (not automatic) module but that
would also require increasing the compiler target from 8 to 9.
Closes #82
|
I was curious to learn more about JPMS so when I saw the related issue I thought it would be a good excuse to finally do that :) |
| <configuration> | ||
| <archive> | ||
| <manifestEntries> | ||
| <Automatic-Module-Name>com.spotify.completablefutures</Automatic-Module-Name> |
There was a problem hiding this comment.
Knowing nothing about JPMS: The package name in use is com.spotify.futures. Should they match?
There was a problem hiding this comment.
It seems like that is the convention but not required, but I figured we'd have a conflict if we ever did the same thing in https://github.com/spotify/futures-extra which has the same package name.
There was a problem hiding this comment.
Yes, in futures-extra we have this: https://github.com/spotify/futures-extra/blob/master/src/main/java/module-info.java#L17
There was a problem hiding this comment.
oh nice, I did not realize there was a proper module-info there already
If the JAR for this repo is used in a project where the module system is
active, Java treats any "plain JAR" without a module descriptor as an
"automatic module" and allows it to be used by other modules in the
application.
For instance, a module in an application using JPMS can depend on this
project like
Defining an
Automatic-Module-Nameallows for explicitly controllingthe name that modules use when loading your automatic module, rather
JPMS guessing at the automatic module name for the JAR based on the
JAR's filename.
Alternatively we could add a
module-info.javato this project toenable it to be loaded as a regular (not automatic) module but that
would also require increasing the compiler target from 8 to 9.
Closes #82