Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field of SpotBugsReport should be Property<T> #597

Closed
KengoTODA opened this issue Oct 27, 2021 · 3 comments
Closed

Field of SpotBugsReport should be Property<T> #597

KengoTODA opened this issue Oct 27, 2021 · 3 comments

Comments

@KengoTODA
Copy link
Member

The SpotBugsReport class provides destination and stylesheet. Their getter methods return not Property<T> but the value itself, so Kotlin build script cannot use .set(...) method to update:

setDestination(file("$buildDir/reports/spotbugs/main/spotbugs.html"))
setStylesheet("fancy-hist.xsl")

It makes build script ununified, so better to change the returned value like public RegularFileProperty getDestination().

@KengoTODA
Copy link
Member Author

destination should be replaced with Report#getOutputLocation().

stylesheet is defined by org.gradle.api.reporting.CustomizableHtmlReport so we need to wait until Gradle official provides alternative methods.

@github-actions
Copy link

🎉 This issue has been resolved in version 5.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant