Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix underscore #40

Merged
merged 2 commits into from
Dec 14, 2015
Merged

Fix/fix underscore #40

merged 2 commits into from
Dec 14, 2015

Conversation

elrrrrrrr
Copy link
Contributor

1.0.0 版本 安装 lodash._getnative 报错

希望能发个小版本修复下 ^ ^

@@ -2,7 +2,7 @@

var debug = require('debug')('spm-client:util');

var ID_REGEX = /^([a-z][a-z0-9\-\.]*)(?:@(.+))?$/;
var ID_REGEX = /^([a-z][a-z0-9\-\._]*)(?:@(.+))?$/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAME_REGEX 也加一个吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk

soda-x added a commit that referenced this pull request Dec 14, 2015
@soda-x soda-x merged commit aa12ad0 into spmjs:master Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants