Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm-chart: add support for image digest #792

Merged
merged 1 commit into from
Jul 29, 2022
Merged

helm-chart: add support for image digest #792

merged 1 commit into from
Jul 29, 2022

Conversation

swarren83
Copy link
Contributor

@swarren83 swarren83 commented Jul 27, 2022 •
edited
Loading

Proposed changes

Add support for image digest under image.tag.

Issue: #793

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@swarren83 swarren83 changed the title Develop Add support for image digest Jul 27, 2022
@swarren83 swarren83 changed the title Add support for image digest helm-chart: add support for image digest Jul 27, 2022
hvaghani221
hvaghani221 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@hvaghani221 hvaghani221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hvaghani221 hvaghani221 merged commit b9a316e into splunk:develop Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvaghani221 hvaghani221 hvaghani221 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swarren83 @hvaghani221