-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terminology to match current WordPress usage #27
Comments
Thanks, @Zodiac1978 … I was just reading up on this change. Along with plugins that access the keys, it will require changing the name of this project, the name of the repo itself, and updating the associated documentation. It looks like I’ll be able to rename the repo and have the old URL redirect automatically. https://docs.github.com/en/github/administering-a-repository/renaming-a-repository |
The name of the option has changed in the final version of WordPress 5.5 to |
Thanks for the update. |
Related to this, the user interface terminology on the Discussion Settings page has changed as well. The Comment Blacklist section has been changed to Disallowed Comment Keys This really futzes up the name of this repository. |
So, here are my thoughts … WordPress 5.3 and earlier use Comment Blacklist All of these variations need to be referenced in the documentation, as you never know what version of WP is being used. While “Disallowed Comment Keys” does make some semantic sense, it feels like a programmer decided to make the change to he text without consulting a copywriter first. (Which in reality, is probably what happened.) “Disallowed Comment Keys” is an incredibly awkward phrase compared to something as straightforward as “Blocklist”. Likewise, changing the repository name to something that matches the interface terminology (eg: “Disallowed Comment Keys List for WordPress”) would be just just silly. Changing “blacklist” to “blocklist” in both the repository name and URL will be in smoothest transition, while still maintaining any necessary documentation updates to address the other changes implemented in the WP interface. |
Addressed the Discussion Settings information in the read me to reflect the various field name iterations in commit de3e332 |
Started changing “blacklist” to “blocklist” in the documentation per commit 9c26553 Still need to research what will happen regarding direct links to the blacklist.txt file if the repo name and file name change. |
Just a heads up:
With the coming WordPress 5.5 the
blacklist_keys
are changed toblocklist_keys
.See this changeset:
https://core.trac.wordpress.org/changeset/48121
For all the people maintaining plugins to update those keys with the list.
The text was updated successfully, but these errors were encountered: