Address code review comments in upstream pr

* upstream pr celo-org#9700 * remove commented code * remove references to fixidity lib in docs * remove unecessary getter definition [#182759476] [Test] y [Review] m-chrzan
spiralsprotocol · Jul 28, 2022 · 1b6ee23 · 1b6ee23
1 parent ea9136d
commit 1b6ee23
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 7 deletions.
diff --git a/packages/cli/src/commands/account/delete-payment-delegation.ts b/packages/cli/src/commands/account/delete-payment-delegation.ts
@@ -22,7 +22,6 @@ export default class DeletePaymentDelegation extends BaseCommand {
     this.kit.defaultAccount = res.flags.account
     const accounts = await this.kit.contracts.getAccounts()
 
-    // await accounts.deletePaymentDelegation()
     await displaySendTx('deletePaymentDelegation', accounts.deletePaymentDelegation())
 
     console.log('Deleted payment delegation.')

diff --git a/packages/cli/src/commands/account/get-payment-delegation.ts b/packages/cli/src/commands/account/get-payment-delegation.ts
@@ -5,7 +5,7 @@ import { Flags } from '../../utils/command'
 
 export default class GetPaymentDelegation extends BaseCommand {
   static description =
-    "Get the payment delegation account beneficiary and fraction allocated from a validator's payment each epoch. The fraction is given as FixidityLib value and cannot be greater than 1."
+    "Get the payment delegation account beneficiary and fraction allocated from a validator's payment each epoch. The fraction cannot be greater than 1."
 
   static flags = {
     ...BaseCommand.flags,

diff --git a/packages/cli/src/commands/account/set-payment-delegation.ts b/packages/cli/src/commands/account/set-payment-delegation.ts
@@ -7,7 +7,7 @@ import { Flags } from '../../utils/command'
 
 export default class SetPaymentDelegation extends BaseCommand {
   static description =
-    "Sets a payment delegation beneficiary, an account address to receive a fraction of the validator's payment every epoch. The fraction is given as FixidityLib value and must not be greater than 1."
+    "Sets a payment delegation beneficiary, an account address to receive a fraction of the validator's payment every epoch. The fraction must not be greater than 1."
 
   static flags = {
     ...BaseCommand.flags,

diff --git a/packages/sdk/contractkit/src/contract-cache.ts b/packages/sdk/contractkit/src/contract-cache.ts
@@ -194,10 +194,6 @@ export class WrapperCache implements ContractCacheType {
     return this.getContract(CeloContract.MultiSig, address)
   }
 
-  getPaymentDelegation() {
-    return this.getContract(CeloContract.Accounts)
-  }
-
   getReserve() {
     return this.getContract(CeloContract.Reserve)
   }