Fix null coercion of scalars #2172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
reviewed
Jan 31, 2025
| vortex_bail!("Boolean operations are only supported on boolean arrays") | ||
| if !lhs.dtype().is_boolean() | ||
| || !rhs.dtype().is_boolean() | ||
| || !lhs.dtype().eq_ignore_nullability(rhs.dtype()) |
There was a problem hiding this comment.
nit: could simplify as !matches!(lhs.dtype(), DType::Boolean(_)) || ...
| To maximise compatibility with compute engines, Vortex does not perform any implicit type coercion in its compute | ||
| functions or expressions. The exception to this is upcasting the nullability of input data types. For example, | ||
| it is valid to compare a `u32` and `u32?` array, resulting in a `bool?` array. |
There was a problem hiding this comment.
What about list(u32)? compared to list(u32?).
|
I think this is blocked on #2174 |
|
Nope.. this seems like it's a DataFusion bug? apache/datafusion#14394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2171